shader-slang / slang-rhi / 26436532508

69%

push

github

Add hash verification for fetched binaries (#755)

* Add hash verification for fetched binaries

* Tighten Slang fetch hash handling

* Address review feedback: fail fast on unsupported macOS architecture in Slang fetch

* Address review feedback: omit Authorization header when SLANG_GITHUB_TOKEN is unset

* Address review feedback: extract SLANG_HASH_VERSION variable and add FATAL_ERROR for unsupported arch on Windows/Linux

* Address review feedback: bare variable STREQUAL, arch in FATAL_ERROR message, quoted URL args

* Ignore local Claude Code session files

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Address review feedback: scope GitHub token to github.com and drop redundant hash guards

- FetchPackage: only attach Authorization header when fetching from
  github.com (or subdomains), so the token is not sent to nuget.org,
  developer.nvidia.com, developer.apple.com, etc.
- CMakeLists: remove inner if(NOT DEFINED ..._URL_HASH) guards inside
  each if(NOT DEFINED ..._URL) block; when we set our known default
  URL we should also unconditionally set the corresponding known hash.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Add SHA-256 hash for Slang Emscripten/wasm-libs binary

The Emscripten branch of the Slang fetch set SLANG_URL but did not
define SLANG_RHI_SLANG_URL_HASH, so the FATAL_ERROR triggered on every
Emscripten configure. Add the known hash for slang-${SLANG_VERSION}-wasm-libs.zip
when the version matches SLANG_HASH_VERSION, mirroring the other platform branches.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Address review feedback: drop redundant NOT DEFINED guard on Slang hash

Per PR review, when SLANG_VERSION matches SLANG_HASH_VERSION we should
always set the known/confirmed hash for that version. Simplify the
inner guards in all 7 Slang fetch branches (Windows/Linux/macOS x86_64
and aarch64, plus Emscripten) from

    if(NOT DEFINED SLANG_RHI_SLANG... (continued)

12048 of 20406 branches covered (59.04%)

Branch coverage included in aggregate %.

35613 of 48946 relevant lines covered (72.76%)

278388.44 hits per line