prisma-risk / tsoracle / 26432330963

95%

push

github

feat(openraft-toolkit): version-neutral e2e-max-readable-next feature (#468)

A test-only Cargo feature that raises `MAX_READABLE_VERSION` to
`BASELINE_WRITE_VERSION + 1` and adds matching alias arms on the
per-version codec dispatch, delegating the next-version body to the
baseline body byte-for-byte. This is the prerequisite for a future
mixed-version e2e harness driving a real activation flip end-to-end
(gate → propose → commit → apply → cell flip) without shipping a real
new format.

**Version-neutral by design.** Both the constant and the alias arms
derive from `BASELINE_WRITE_VERSION + 1` (not a literal `5`), and the
feature name (`e2e-max-readable-next`, not `-5`) does not bake in the
current baseline. When the production baseline bumps from 4 to 5, the
alias automatically becomes 6 with no edits to the feature name, the
arm guards, or the round-trip test.

**Toolkit changes** (`tsoracle-openraft-toolkit`).

- New `e2e-max-readable-next` feature in `Cargo.toml`.
- `MAX_READABLE_VERSION` becomes `cfg`-split: still `= 4` in the
  default build; `= BASELINE_WRITE_VERSION + 1` under the feature.
- The pre-existing `version_constants_are_at_the_v4_baseline` test
  is gated `#[cfg(not(...))]` and complemented by a new
  `version_constants_under_e2e_max_readable_next_feature` test under
  the feature, asserting `MAX == BASELINE + 1` against the expression
  so a future baseline bump leaves the assertion correct.
- The `log_store::record_codec_tests::version_constants_are_at_four`
  pin and its `MIN_READABLE_VERSION` / `MAX_READABLE_VERSION`
  imports get the same `#[cfg(not(...))]` gate (the codec.rs test
  covers the feature-on case).
- `unframe_with_version` (toolkit log store) converted to
  `(MIN..=MAX).contains(&version)` — clippy fires
  `manual_range_contains` once `MIN < MAX`, which the previous
  `version < MIN || version > MAX` form would have hit on any
  future range widening regardless. Pre-emptive cleanup.

**Driver changes** (`tsoracle-... (continued)

39 of 43 new or added lines in 3 files covered. (90.7%)

12979 of 13596 relevant lines covered (95.46%)

417975.19 hits per line