jacob-meacham / rotary-voip / 26430541998

59%

push

github

fix(gpio): use push-pull drive on outputs (was inadvertently open-drain)

For input pins, lgpio's lFlags parameter encodes bias (SET_PULL_NONE,
SET_PULL_UP, SET_PULL_DOWN). For output pins, the same lFlags parameter
encodes drive mode (DRIVE_PUSH_PULL=0, DRIVE_OPEN_DRAIN=1,
DRIVE_OPEN_SOURCE=2, ACTIVE_LOW=4). The integer values overlap.

We were passing SET_PULL_NONE (=1) as lFlags to gpio_claim_output for
outputs, which lgpio interprets as DRIVE_OPEN_DRAIN — the pin can pull
LOW but can only float HIGH. The PAM8302's internal pull-up on its EN
pin was usually enough to keep EN HIGH when we wanted, but this is
unreliable — temperature, supply variation, or even a slightly
different PAM8302 batch can flip the polarity to "amp on when GPIO is
LOW", which is what the user just observed.

Pass 0 to select the default DRIVE_PUSH_PULL so HIGH actually drives
the pin to 3.3V.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

0 of 2 new or added lines in 1 file covered. (0.0%)

2396 of 4082 relevant lines covered (58.7%)

0.59 hits per line