moonbitlang / x / 808

87%

push

github

perf(path): write StringView components via write_view instead of copying to_owned

UnixPath::Show::output and WinPath::Show::output wrote each
path component as logger.write_string(x.to_owned()) where x is a
StringView. to_owned() copies the view into a newly allocated String,
which write_string then copies again into the builder -- one
allocation + two copies per component, where Logger already exposes
write_view(StringView) doing the job in a single step.

Path::normalize(p) is UnixPath::parse(p.0).to_string(), so every
normalize goes through Show::output and pays the per-component copy.

path_normalize bench (native, 3-run median, 10-segment path with ..
and . x 200k iters):
  baseline: 282 ms
  patched : 209 ms  (-25.9%)

4 of 4 new or added lines in 2 files covered. (100.0%)

2334 of 2681 relevant lines covered (87.06%)

341.71 hits per line