ben-manes / caffeine / #5480

100%

master: 100%

push

github

Fix missing exception handling in LoadingCache.refresh()

When a user-supplied Expiry or Weigher throws during the refresh
completion handler's compute call, the exception was silently swallowed
because CompletableFuture.whenComplete captures it into a discarded
future. This caused loadFailureCount to be permanently under-counted
and no warning to be logged. Both sibling implementations
(BoundedLocalCache.refreshIfNeeded and LocalAsyncLoadingCache
.tryComputeRefresh) already had the try/catch; this aligns
LocalLoadingCache.refresh with them.

4004 of 4010 branches covered (99.85%)

19 of 19 new or added lines in 2 files covered. (100.0%)

8202 of 8202 relevant lines covered (100.0%)

1.0 hits per line