prisma-risk / tsoracle / 26414238840

95%

push

github

refactor(core): extract validate_count to dedup the allocator count guard (#428)

try_grant and would_grant each carried their own copy of the count
bounds check (count == 0 || count > LOGICAL_MAX + 1). The server's
extension single-flight (service::extend_window) skips a consensus
round-trip whenever would_grant returns true, trusting that the retry
try_grant will then succeed. The count guard was the one rejection rule
duplicated verbatim between the two paths, so a future edit to one and
not the other could drift the rejected-count sets apart and degrade the
recheck into a spurious INTERNAL (or a skipped-then-failing extension)
under load.

Route both methods through a single private validate_count helper, next
to the existing project_grant helper that already centralizes the
window-advance simulation. Behavior is unchanged: try_grant's two former
branches (InvalidCount(0) for zero, InvalidCount(count) for oversized)
collapse to one InvalidCount(count), which is identical when count is 0;
would_grant still returns false via is_err().

8 of 8 new or added lines in 1 file covered. (100.0%)

10323 of 10688 relevant lines covered (96.58%)

554988.23 hits per line