prisma-risk / tsoracle / 26413543622

95%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(server): consolidate consensus-error classification into one classifier (#424)

The extend path (service::extend_window) and the fence path
(fence::run_leader_watch) both classified ConsensusError::{Fenced, NotLeader,
TransientDriver, PermanentDriver}, but with divergent policy and the knowledge
split across two near-identical match blocks, so a fifth variant meant editing
both.

Introduce PersistDisposition and classify(ConsensusError) in a new
persist_disposition module. classify owns the variant-to-category mapping once;
each site maps a disposition to its own policy, making the divergence explicit
at the call sites: the extend path surfaces a transient fault as UNAVAILABLE and
a permanent one as INTERNAL while staying serving, whereas the fence retries a
transient fault with backoff and treats a permanent one as fatal.

PersistDisposition collapses Fenced and NotLeader into
SteppedDown { fenced_by: Option<Epoch> }: both sites step down on either,
differing only in the epoch advertised in the leader hint (Fenced names
current; NotLeader exposes none), which the field preserves. Behavior is
unchanged; the leadership_churn suite pins both paths.

Coverage Stats

72 of 78 new or added lines in 3 files covered. (92.31%)

1 existing line in 1 file now uncovered.

10146 of 10505 relevant lines covered (96.58%)

564873.3 hits per line