Qiskit / qiskit / 26394827629

88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix import order of `circuit` and `synthesis` (#16252)

Synthesis is a higher-level concept than the descriptions of the library
gates themselves.  While `qiskit.synthesis` is frequently used to
provide the "default" synthesis of various library gates (the
`Instruction.definition` field), those should be runtime-resolved
imports, and it should be possible to completely resolve the
`qiskit.circuit` module import before starting the import of
`qiskit.synthesis`.

Being stricter about intended import order makes the logical separation
of concerns clearer, but also lets us write our packages and imports
using a proper public-interface setup.  If we're lax, we end up having
so many files importing hyper-specific imports that make it
unnecessarily hard to refactor later, and make annoying import cycles
when modifying code.

Coverage Stats

16 of 16 new or added lines in 6 files covered. (100.0%)

15 existing lines in 4 files now uncovered.

108455 of 123929 relevant lines covered (87.51%)

958459.68 hits per line