raystack / frontier / 26393323108

43%

main: 43%

Build Type

Pull #1648

github

Committed by AmanGIT07

Commit Message

revert: drop policy.Service.List principal-type validation

The previous commit added validation to refuse `policy.Filter{PrincipalType: X}`
without a matching `PrincipalID` or `PrincipalIDs`. That over-restricted the
legitimate `ListPrincipalsByResource` shape (`{OrgID/ProjectID/GroupID, PrincipalType}`),
breaking 14 regression tests across `ListGroupUsers`, `ListOrganizationUsers`,
and `ListProjectUsers`.

The behaviour the validation was meant to gate — `ListProjectsByUser(id: "")`
returning every project — is consistent with the codebase convention that
listing RPCs return all rows when called without a narrowing filter, and the
RPC is already super-admin gated by the interceptor. Not a bug.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #1648: refactor(project): migrate ListByUser callers to membership, delete legacy method

Coverage Stats

35 of 40 new or added lines in 9 files covered. (87.5%)

2 existing lines in 1 file now uncovered.

16198 of 37845 relevant lines covered (42.8%)

11.98 hits per line