jacob-meacham / rotary-voip / 26384958031

59%

push

github

feat(dial): use off-normal switch as digit gate

Refactors DialReader so a digit is delimited by the off-normal switch
(DIAL_ACTIVE) instead of an inter-pulse timeout. This eliminates two
classes of bug:

1. Phantom pulses fired by the off-normal contact-close glitch when
   the user starts to slowly pull the dial. With the gate model these
   land inside a configurable settle window after DIAL_ACTIVE goes LOW
   and are discarded by design.

2. Long delays before a digit is recognized — emission now happens on
   DIAL_ACTIVE rising (dial fully home), not after pulse-timeout
   silence.

Wiring requirement: blue goes to GND, yellow to GPIO27 (pulse). This
ordering matters because the dial internally bridges blue/red/white
when the off-normal is closed; with blue on GND, GPIO22 (off-normal,
read on red) stays cleanly LOW for the whole dial cycle and rises
only when the dial is fully returned. See HARDWARE.md and CLAUDE.md.

Removes pulse_timeout from config (no longer used). Adds
pulse_settle (default 150 ms). Updates test_harness simulate helpers
and integration-test simulator to drive DIAL_ACTIVE around the pulse
train so existing tests still pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

56 of 61 new or added lines in 1 file covered. (91.8%)

2408 of 4043 relevant lines covered (59.56%)

0.6 hits per line