prisma-risk / tsoracle / 26384812211

95%

push

github

fix(paxos-toolkit): keep RocksdbStorage cursor on out-of-range empty truncate (#401)

append_on_prefix set next_idx to `(from_idx + count).max(compacted_idx)`
unconditionally after the batch. That post-condition only holds when
`from_idx <= current_tail`. For the edge case `append_on_prefix(from_idx >
tail, entries = [])` the delete_range removes no keys and nothing is
written, so the physical log tail is unchanged — but the cache leapt to
from_idx. get_log_len then reported a phantom length and the next
append_entry wrote at the inflated index, leaving a gap on disk.

Derive the new tail from what the batch actually changed, matching the
highest surviving log key a reverse scan would find: `count > 0` keeps
`from_idx + count`; `count == 0` uses `from_idx.min(next_idx)`, so an
out-of-range empty truncate removes no keys and leaves the cursor put.
Both remain floored at the compaction offset. In normal operation
from_idx <= current_tail always, so this is purely a hardening of the
out-of-range corner with no behavior change. The count > 0 case is left
intact: it writes a real on-disk gap that the cache correctly mirrors.

22 of 22 new or added lines in 1 file covered. (100.0%)

9181 of 9596 relevant lines covered (95.68%)

554389.98 hits per line