dangernoodle-io / breadboard / 26382692810

100%

push

github

fix(bb_mdns): relocate txt[] pointers after batch struct copy (#311)

PR #309's coalescing copies bb_mdns_evt_t by struct assignment, which
duplicates payload[] but leaves txt[i].key/value pointing into the source
evt's payload. By the time the dispatcher fires (post-flush, ~50ms later
on a different task), the source evt has gone out of scope and the txt
pointers are dangling.

Symptom: knot (TM mDNS browse consumer) sees empty TXT records — peer
version/board/state fields all missing in /api/knot. Affects all consumers
of bb_mdns_browse_start TXT data.

Fix: after the struct copy, compute the offset between destination and
source payloads, relocate each non-NULL txt[i].key/value pointer.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

1334 of 1334 branches covered (100.0%)

Branch coverage included in aggregate %.

2268 of 2268 relevant lines covered (100.0%)

912.72 hits per line