prisma-risk / tsoracle / 26381108978

95%

push

github

fix(openraft-toolkit): version-frame the log-store meta column (#331) (#390)

The meta column holds openraft's recovery-critical Vote/Committed/LastPurged,
yet `log_store/meta.rs` persisted them as bare, unversioned postcard — unlike
every other persisted blob in the store, which is framed `[SCHEMA_VERSION |
postcard]` and loud-rejects a foreign version. After a layout-changing upgrade
a `Vote` could misdecode against the new shape silently, corrupting term and
leader-election safety, instead of failing with a version error. A regression
test demonstrates the hazard: an injected foreign-version record decodes into a
valid-looking but wrong `Vote`.

Route `meta::read`/`put` through the same `encode_record`/`decode_record`
helpers the log column uses, so meta gets the version frame and surfaces a
foreign version as `InvalidData`. Those helpers return `io::Result`, matching
the `RaftLogStorage` trait surface; this leaves `open()` as the only producer
of `RocksdbLogStoreError` (emitting just `MissingColumnFamily`), so the now-dead
`Decode` and `RocksDb` variants are removed and the unused `postcard`
dependency dropped.

Framing the meta column is a breaking on-disk change, so `SCHEMA_VERSION` is
bumped 1 -> 2 and the golden-byte layout pins advance with it; a meta-column
pin is added for the Vote record.

Closes the deferred half of #93.

19 of 21 new or added lines in 3 files covered. (90.48%)

12590 of 13271 relevant lines covered (94.87%)

433740.06 hits per line