prisma-risk / tsoracle / 26380284228

95%

push

github

fix(core): name all operands on window-extension overflow (#384)

try_prepare_window_extension returned PhysicalMsOutOfRange(u64::MAX) as a
hardcoded placeholder when max(floor, now_ms) + ahead_ms overflowed,
discarding the real operands. A saturated SystemClock (now_ms saturates
to u64::MAX) plus any non-zero ahead_ms reaches this path, and the log
then reads as "someone passed an absurd physical_ms" when the real cause
was a misconfigured clock.

Add CoreError::WindowExtensionOverflow { floor, now_ms, ahead_ms } and
return it at the overflow site so the error names all three inputs,
making a saturated now_ms distinguishable from a large ahead_ms. The
sibling floor overflow and the out-of-range check are unchanged.

Map the variant to Status::internal in core_status: the operands are
server-side (clock plus window config), not client-supplied, so it is a
server fault like InvalidLeadershipWindow rather than an out_of_range
request.

Closes #339

15 of 20 new or added lines in 2 files covered. (75.0%)

12455 of 13129 relevant lines covered (94.87%)

482193.67 hits per line