prisma-risk / tsoracle / 26379921763

95%

push

github

fix(driver-paxos): reject double-start with AlreadyRunning instead of a debug-only assert (#380)

StandaloneHost::start enforced its "must not be called while already
running" invariant with debug_assert!, which compiles away in release.
A double-start there (no intervening stop, which take()s the handle)
silently overwrote self.task, orphaning the prior apply task (duplicate
apply loops folding into one high-water) and leaking the runner's tick
task.

Replace the assert with a real runtime guard: start now returns
Result<(), AlreadyRunning> and short-circuits before either the apply
task or the runner tick task is spawned, so a rejected call spawns
nothing and never orphans the live tasks, in any build profile.
self.task stays the single "running" signal; stop() take()s it, so the
host is startable again afterwards.

Callers updated to handle the Result. Adds a regression test pinning
the start -> Err(AlreadyRunning) -> stop -> start lifecycle.

Closes #355

10 of 10 new or added lines in 2 files covered. (100.0%)

12299 of 12963 relevant lines covered (94.88%)

465136.65 hits per line