prisma-risk / tsoracle / 26379535391

95%

Build Type

push

github

Committed by web-flow

Commit Message

fix(client): decompose retry loop and stop redirects consuming the attempt budget (#376)

`issue_rpc`/`attempt` in retry.rs jointly owned five concerns (worklist +
visited-set dedup, three-tier deadline arithmetic, backoff scheduling, the
NOT_LEADER classification tree, and channel eviction), making the
most-churned file in the crate risky to change. Pull the orthogonal
concerns behind named, independently-testable types:

- `worklist::Worklist` owns the queue, the visited-set dedup, and the
  push-front-on-hint steering. `next()` folds the skip-already-visited
  short-circuit; `redirect_to()` is the front-insertion.
- `budget::Budget`/`PairBudget` own all three deadline tiers: the overall
  cap, the per-attempt cap (`next_attempt()` returns None once the overall
  deadline is reached), the backoff-vs-remaining clamp, and the
  connect/get_ts pair-split.
- The "transport-class failure ⇒ evict the cached channel" invariant
  (#239), previously duplicated at two RPC-failure sites in `attempt`, now
  lives in one auditable tail: a single `is_transport_failure` gate. The
  timeout arm's DeadlineExceeded is transport-class, so it evicts
  identically — behavior preserved.

Fold in the redirect-budget fix: replace the single attempt counter with
`failed_attempts`, incremented only on `AttemptOutcome::Err`. Leader-hint
redirects (LeaderHint/StaleLeaderHint/HintRejected) no longer consume the
`max_attempts` budget or inflate the backoff exponent, so a legitimate
failover redirect chain longer than `max_attempts` can still reach the
live leader instead of surfacing the last hint status. Redirects stay
bounded by the worklist visited-set and the overall deadline.

New direct unit tests cover the worklist dedup/redirect semantics and the
budget deadline math without sockets; a new integration test drives a
redirect chain longer than `max_attempts` through the real loop to a live
leader.

Closes #332
Closes #340

Coverage Stats

211 of 221 new or added lines in 3 files covered. (95.48%)

2 existing lines in 2 files now uncovered.

12278 of 12942 relevant lines covered (94.87%)

401400.96 hits per line