ben-manes / caffeine / #5476

100%

push

github

Fix remaining simulator policy bugs found by temporal walk audit

- TinyCache: remove dead-code modulus and try/catch debugging scaffold
  from chain-walk loops in TinyCache, TinyCacheSketch, and
  TinyCacheWithGhostCache (indices are always in-bounds by construction)
- TinyCacheAdapter: floor nrSets to 1 to prevent zero-length arrays
  and ArithmeticException for maximumSize < 7
- SimpleClimber/SimulatedAnnealingClimber: drop vestigial 100x
  multipliers on tolerance thresholds and SA acceptance exponent to
  match the [0,1] hit-rate scale from AbstractClimber
- FeedbackTinyLfuPolicy: only consume the per-period adaptation slot
  when gain actually changes, so boundary no-ops don't block valid
  adjustments
- FeedbackWindowTinyLfuPolicy: remove redundant admitter.record() in
  onProtectedHit (was double-counting frequency for protected hits);
  same adjusted-slot fix as FeedbackTinyLfu; guard the increase loop
  against removing the probation sentinel when the list has only one
  node
- SystorTraceReader: divide byte offset by BLOCK_SIZE to produce
  block-level keys consistent with the block-count sequence

4003 of 4010 branches covered (99.83%)

8198 of 8198 relevant lines covered (100.0%)

1.0 hits per line