prisma-risk / tsoracle / 26378349683

95%

push

github

feat(consensus): give the high-water advance rule a single home via AdvancePayload::merge (#369)

The monotonic apply rule — current = max(current, at_least) — was
reimplemented inline at three apply sites across two driver crates:
paxos drain_decided_into, paxos HighWaterSnapshot::create, and openraft
apply. Add AdvancePayload::merge(self, current) -> u64 in
tsoracle-consensus as the single named home for the invariant, give it
one test, and call it at all three sites.

Behavior is unchanged: each site previously ran `if at_least > current`
and the method returns the same max. The paxos drain site keeps its
`if new > prev` guard so the "high-water advanced" trace still fires
only on a real advance.

Labelled feat rather than the issue's refactor because it adds a public
method to a library crate consumed by the driver crates; under the
release_commits = "^(feat|fix|perf)" filter a refactor-labelled
public-API add would not publish a new tsoracle-consensus version, so a
dependent referencing the new symbol would fail cargo publish --verify
against the stale registry.

Closes #348

24 of 29 new or added lines in 4 files covered. (82.76%)

12045 of 12705 relevant lines covered (94.81%)

433545.53 hits per line