prisma-risk / tsoracle / 26377892354

95%

push

github

feat(core): return CommitOutcome from try_commit_window_extension (#365)

try_commit_window_extension collapsed four distinct results into Ok(()):
the bound was raised, or the commit was dropped because the node was not
leader, targeted a superseded epoch, or did not advance the bound. A
server that just paid for a persist_high_water round-trip could not tell
"I raised the bound" from "I silently dropped your durably-persisted
value."

Return Result<CommitOutcome, CoreError>, where CommitOutcome is
Applied(u64) or Ignored(IgnoreReason). IgnoreReason splits the three
benign drops into NotLeader, EpochMismatch, and NotAdvanced so a caller
can distinguish epoch churn from persist reordering. An out-of-range
value stays Err(PhysicalMsOutOfRange): an invariant violation, not a
benign drop. The epoch check is ordered before the advance check so a
late persist from a superseded epoch always reports churn.

The server now consumes the outcome: an ignored commit emits a debug log
and increments a per-reason counter (tsoracle.window.extensions.ignored.*),
documented in docs/operations.md as a leading indicator of epoch churn or
persist reordering.

Closes #338

58 of 60 new or added lines in 2 files covered. (96.67%)

11796 of 12436 relevant lines covered (94.85%)

454134.99 hits per line