prisma-risk / tsoracle / 26377529042

95%

Build Type

push

github

Committed by web-flow

Commit Message

fix(client): make record_success epoch-monotone (#362)

record_success was the weaker of the two writers to the leader cache's
epoch field. compare_and_set_leader (#240/#274) is carefully
monotone-forward, but record_success unconditionally wrote
cached.epoch = Some(epoch) for the cached endpoint and installed a fresh
entry for any other endpoint with no epoch comparison. A late-completing
RPC against a now-deposed leader -- a normal failover artifact, or
out-of-order completion of two coalesced retries -- could therefore lower
the cached epoch. Once lowered, compare_and_set_leader would accept a
genuinely-stale leader hint it was designed to reject: the monotone gate
is only as strong as its weakest writer.

Same endpoint: max the epoch instead of overwriting, still refreshing
last_used (the endpoint just proved it is alive, so it keeps its worklist
slot regardless of how stale the observed epoch was). Different endpoint:
replace the entry unless the cache is fresh, both epochs are known, and
the new epoch is strictly below the cached one -- the same rule
compare_and_set_leader applies, so an expired entry or an unknown cached
epoch still imposes no floor.

Coverage Stats

62 of 64 new or added lines in 1 file covered. (96.88%)

3 existing lines in 2 files now uncovered.

11645 of 12280 relevant lines covered (94.83%)

428327.86 hits per line