prisma-risk / tsoracle / 26375115934

95%

push

github

feat(client): expose Client::cached_leader() and drop the dead pool field (#329)

The `Client::pool: Arc<ChannelPool>` field was marked `#[allow(dead_code)]`
because the driver closure captures its own `Arc<ChannelPool>` clone, so the
field on `Client` was never read.

Rather than delete the field, make it live by exposing the pool's existing
leader-cache accessor as `Client::cached_leader() -> Option<String>`: a
read-only diagnostic surface for ops dashboards and integration tests that
want to assert a client has converged to the expected leader. It reflects the
cache as last updated by a completed RPC — it neither triggers nor waits on a
round-trip, and the TTL check is lazy (an expired entry reads as `None`).

This removes the misleading `allow(dead_code)` annotation from the public
`Client` type while buying observability for the same surface area.

Tests:
- in-crate unit test: a freshly connected client reports `None` before any RPC
- end-to-end test in tsoracle-tests: a successful GetTs over the real gRPC
  stack seats the serving endpoint as the cached leader

Closes #96

9 of 9 new or added lines in 1 file covered. (100.0%)

11429 of 12044 relevant lines covered (94.89%)

462059.58 hits per line