prisma-risk / tsoracle / 26373779888

95%

push

github

refactor(server): extract shared serve_inner from the two serve paths (#322)

serve_with_shutdown and serve_with_listener were ~90% identical: both
set up a cancel oneshot, build a combined shutdown future, pin the serve
future, and run the same biased select with the abort and
combine_watch_and_drain translation. Only the serve-future construction
differed (address-bound serve_with_shutdown vs listener-bound
serve_with_incoming_shutdown), so any future change to the drain or
error-mapping logic had to be made twice.

Extract two private helpers:

- serve_inner(watch_handle, serve_future, cancel_tx) owns the pin, the
  biased select, the abort path, and the drain/translate logic.
- combined_shutdown_with_cancel(shutdown) owns the oneshot plus the
  merged shutdown future, the other duplicated half.

Both public methods now build only their serve future and delegate.
All explanatory comments move to serve_inner's single home. No public
API or behavior change; the existing embedded_router, serve_shutdown,
and server_serve_with_listener tests pass unchanged.

Closes #92

38 of 38 new or added lines in 1 file covered. (100.0%)

11308 of 11911 relevant lines covered (94.94%)

479883.48 hits per line