mcallegari / qlcplus / 26368427200
35%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 197
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 35.037%. Remained the same
26368427200

push

github

web-flow 
Fix QML null dereferences and VC component memory leak (#2027)

* QML: handle stale waveform image ids

Origin: found while reviewing the PR #1955 bug list; not reported in
PR #1955.

Request `image://waveform/<invalid-id>` from QML, or keep a
Show Manager audio item image source alive after deleting the
underlying Audio function. The image provider called
`m_doc->function(fid)->type()` before checking that the function
lookup returned an object, so a stale id dereferenced a null pointer.

Return an empty image for missing functions, as the provider already
does for invalid ids and non-audio functions.

No automated regression test exists for this QML image provider path.

Signed-off-by: Christoph Müllner <christophm30@gmail.com>

* QML VC: release temporary components after render

Origin: reported in PR #1955. The upstream partial fix released
QQmlComponent objects on the error path, but the successful creation
path still kept each temporary component alive.

Open the QML Virtual Console, then repeatedly reload or rebuild widget
trees while observing allocations with a leak checker or profiler. Each
rendered VC widget created a temporary QQmlComponent and retained it
after component->create() succeeded.

Delete the temporary component immediately after creating the QQuickItem
and skip property setup if item creation fails.

No automated regression test exists for this QML lifetime path.

Signed-off-by: Christoph Müllner <christophm30@gmail.com>

* QML: guard fixture delegate lookups

Origin: reported in PR #1955, with adjacent fixture-view cases found
while reviewing the same Repeater.itemAt() pattern.

Open the QML fixture console or tree-based fixture/function views while
loading a project or switching views. Model updates can arrive before
all Repeater delegates exist, and tree hit testing can land over empty
space. The affected code dereferenced itemAt() results immediately and
could throw QML TypeError exceptions.

Skip missing fixture delegate... (continued)

18293 of 52211 relevant lines covered (35.04%)

41158.64 hits per line

Jobs
ID Job ID Ran Files Coverage
1 26368427200.1 197
35.04
 GitHub Action Run
Source Files on build 26368427200