KarpelesLab / goro / 26359629988

12%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: lower runObjectDynVar (nullChain) + runObjectDynFunc to dedicated opcodes

Three small cleanups to drain the generic-OpClassConst delegation pool:

1. IsObjectDynVarReadNode now accepts nullChain variants too.
   The OP_OBJECT_DYN_GET handler already short-circuits when the
   nullsafe flag is set; nullChain wants the same semantics
   (propagated null from an outer nullsafe element), so route both
   through the same path with ObjectDynVarIsNullSafe returning
   nullsafe||nullChain. Removes the runObjectDynVar entry from
   IsValueExprAstDelegated.

2. Add OP_OBJECT_DYN_CALL + EvalObjectDynFunc helper for
   $obj->{$expr}(args) / Foo::{$expr}(args) dyn-method-name
   calls. Stage 1 (cosmetic): the helper body is runObjectDynFunc.Run
   verbatim, but the dispatch is now via a dedicated opcode instead of
   the generic OpClassConst path. Adds IsObjectDynFuncNode predicate
   and an emit branch that emits the call, refreshes slots, and pops
   in statement context.

3. IsValueExprAstDelegated now always returns false. Every previously
   listed node type (runnableClone non-basic, runObjectDynVar,
   runObjectDynFunc, runRef) routes through a dedicated opcode earlier
   in the emit dispatch (IsCloneExtNode / IsObjectDynVarReadNode /
   IsObjectDynFuncNode / IsRefNode). The function is retained as a
   single hook in case a future node ever needs the generic
   delegation again.

Slot-safety unchanged: runObjectDynFunc bodies still mark the enclosing
function slot-unsafe (the helper calls AST.Run which reads from the
FuncContext hashtable).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

7 of 35 new or added lines in 4 files covered. (20.0%)

1 existing line in 1 file now uncovered.

14752 of 118226 relevant lines covered (12.48%)

2585.83 hits per line