KarpelesLab / goro / 26351382778

12%

push

github

vm: unwrap receiver + caller-scope private resolution in CallInstanceMethodByExprs

CallInstanceMethodByExprs (the B9-Stage1 helper that handles object
method calls with by-ref/named/spread args) was missing two pieces of
the AST runner's dispatch logic that the existing CallInstanceMethod
path also lacks but happens to not be exercised by tests:

1. Unwrap the receiver's kin marker before method lookup so a parent
   method calling $this->childMethod() resolves through the actual
   runtime class's vtable, not the narrowed parent class. Without
   this, add_optional_by_ref_arg.phpt regressed (Test1.method1 called
   Test1.method2 instead of Test2.method2 on a Test2 instance).

2. Re-resolve private methods through the caller's class scope.
   Private methods are not virtual: when calling $this->method()
   from within a class that defines a private method with that name,
   PHP uses the caller's private method regardless of what the
   runtime class hierarchy provides. Without this, bug69180-backtrace
   regressed (P extends Model, both define private __t_get; calling
   $this->__t_get from Model.__get on a P instance found P's private
   method and threw a visibility error).

Both fixes mirror runObjectFunc.Run (compile-object.go ~880,~912).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

13 of 21 new or added lines in 1 file covered. (61.9%)

14742 of 118194 relevant lines covered (12.47%)

2579.01 hits per line