prisma-risk / tsoracle / 26351079365

95%

Build Type

push

github

Committed by web-flow

Commit Message

fix(server): surface reflection descriptor decode failure as a recoverable error (#9) (#283)

Server startup registered the gRPC reflection descriptor with
`.expect("FILE_DESCRIPTOR_SET emitted by build.rs is always valid")`,
turning the (highly unlikely) build-artifact drift case into a process
panic. Replace it with explicit error mapping propagated from the
server-construction path.

`into_router` now returns `Result<(Routes, JoinHandle), ServerError>`,
building the reflection service via a new `build_reflection_service`
helper before the leader-watch task is spawned so a decode failure
returns `ServerError::ReflectionInit` without leaking a running task.
The new variant is gated on the `reflection` feature. All in-repo
callers (the two `serve_*` methods, embedded-router/failpoints tests,
and the failover-demo example) and the docs that describe the return
shape are updated accordingly.

Adds focused unit tests covering both the embedded descriptor (Ok) and
a corrupt descriptor (typed error) paths.

BREAKING CHANGE: `Server::into_router` now returns
`Result<(Routes, JoinHandle<Result<(), ServerError>>), ServerError>`
instead of the tuple directly; embedders must handle or propagate the
error.

Coverage Stats

28 of 29 new or added lines in 1 file covered. (96.55%)

4 existing lines in 1 file now uncovered.

10635 of 11226 relevant lines covered (94.74%)

536953.24 hits per line