prisma-risk / tsoracle / 26350814947

95%

push

github

fix(core): return NotLeader from try_prepare_window_extension off-leader (#251) (#280)

Every other mutating method on Allocator returns Err(CoreError::NotLeader)
for a non-leader, but try_prepare_window_extension returned Ok(0) — a value
indistinguishable from a legitimately prepared bound. A caller that skipped
is_leader() would proceed as if preparation had succeeded.

The NotLeader arm now returns Err(CoreError::NotLeader). In the server's
extend_window the arm was already unreachable (the allocator lock is held
across both the epoch() pre-check and the prepare call), so production
behavior is unchanged; the fix hardens the contract for future callers.

The monotonicity proptest relied on the Ok(0) sentinel: it called prepare
on every random Op::Extend, including off-leader sequences. It now gates the
prepare+commit behind the leader check, which is the pre-check callers should
perform anyway.

6 of 6 new or added lines in 1 file covered. (100.0%)

10627 of 11209 relevant lines covered (94.81%)

544698.68 hits per line