prisma-risk / tsoracle / 26349374607

95%

Build Type

push

github

Committed by web-flow

Commit Message

fix(client): preserve status on stale-epoch hint so it surfaces NOT_LEADER (#237) (#270)

The retry loop's `StaleLeaderHint` arm bumped `attempt_index` and continued
but never assigned `last_err`. When the worklist then emptied with only
stale-epoch redirects (no Ok, no recorded error), `issue_rpc` returned
`last_err.unwrap_or(ClientError::NoReachableEndpoints)` — so the caller saw
`NoReachableEndpoints` for what was actually a stale-epoch `NOT_LEADER`.
That is common during epoch transitions and mixed-version clusters, and it
misleads callers: the network was fine, the contacted peer just pointed at
an out-of-date leader.

Thread the originating `FAILED_PRECONDITION` status through
`AttemptOutcome::StaleLeaderHint(tonic::Status)` and record it as `last_err`
before continuing. The arm still keeps the cache and skips backoff. A new
test drives the real `issue_rpc` loop against a loopback peer that only ever
returns a strictly lower-epoch hint and asserts the surfaced error is
`Rpc(FAILED_PRECONDITION)`, not `NoReachableEndpoints`.

Coverage Stats

44 of 53 new or added lines in 1 file covered. (83.02%)

1 existing line in 1 file now uncovered.

10433 of 11018 relevant lines covered (94.69%)

556209.66 hits per line