KarpelesLab / libwallet / 26345790451
22%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 123
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 22.08%. Remained the same
26345790451

push

github

MagicalTux 
dart/ios: drop -force_load + static_framework — Go in framework only

0.4.43 reached for `s.static_framework = true` to stop CocoaPods
from packaging libwallet twice (the dynamic framework wrapper plus
the static `.a` force-loaded into Runner). It worked for the
dual-runtime, but moved the Objective-C bridge into Runner as a
hidden-visibility static lib symbol that dlsym couldn't see; the
test app then failed to look up libwallet_init at FFI init.

0.4.44 layered on `-Wl,-export_dynamic` + per-function
`visibility("default")` to expose the bridge to dlsym in Runner.
Neither worked end-to-end (still "symbol not found").

The simpler fix that should have been the first try: stop linking
libwallet.a into Runner at all. The libwallet pod is fine as a
normal dynamic framework (Flutter's `use_frameworks!` default) —
the framework already contains the Go runtime and the bridge,
its exported symbols are in the dylib's export trie, and
`dlsym(RTLD_DEFAULT, libwallet_init)` walks every loaded image so
it'll find the bridge there. Runner doesn't need its own copy.

Podspec delta vs 0.4.42:
  - Drop `s.user_target_xcconfig` (the `-force_load` it added is
    what caused the duplicate Go runtime in the first place).
  - Drop `s.static_framework = true` (was a workaround for the
    duplicate; the duplicate is gone with -force_load removed).
  - Keep `s.pod_target_xcconfig['GCC_SYMBOLS_PRIVATE_EXTERN'] = 'NO'`
    and the bridge's per-function `visibility("default")` — both
    are belt-and-suspenders so any future pod source files keep
    their symbols visible to dlsym without each maintainer
    re-litigating the linker flags.

CHANGELOG entry under 0.4.45.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

4027 of 18238 relevant lines covered (22.08%)

102.49 hits per line

Jobs
ID Job ID Ran Files Coverage
1 26345790451.1 123
22.08
 GitHub Action Run
Source Files on build 26345790451