KarpelesLab / libwallet / 26345173435
22%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 123
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 22.08%. Remained the same
26345173435

push

github

MagicalTux 
dart/ios: add -export_dynamic so dlsym finds the bridge under static_framework

0.4.43's `s.static_framework = true` change fixed the dual Go
runtime by stopping CocoaPods from wrapping the libwallet pod into
a dynamic framework — but it inadvertently moved the
Classes/LibwalletBridge.m symbols (`libwallet_init`, `libwallet_request`,
…) out of a dylib (where they were auto-exported) and into Runner's
binary as a statically-linked-in static library.

Apple's linker only puts `_main`-reachable globals in an executable's
export trie by default. The bridge functions are kept alive via
`__attribute__((used))` so dead-strip leaves them in Runner's binary,
but the export trie — what `dlsym(RTLD_DEFAULT, ...)` walks — doesn't
include them. So Dart FFI's `DynamicLibrary.process().lookup('libwallet_init')`
throws "symbol not found" at startup, the integration-test setUpAll
fails before any test runs.

Fix: add `-Wl,-export_dynamic` to user_target_xcconfig.OTHER_LDFLAGS
for both SDK slots. Unlike `-exported_symbol` (an exclusive allowlist
that breaks because it strips `_main`), `-export_dynamic` is
additive — every default-visibility kept global gets added to the
export trie alongside `_main`. Pairs with 0.4.43's `static_framework = true`;
both are now load-bearing together.

CHANGELOG entry under 0.4.44. End-to-end iOS validation lands on CI.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

4027 of 18238 relevant lines covered (22.08%)

102.52 hits per line

Jobs
ID Job ID Ran Files Coverage
1 26345173435.1 123
22.08
 GitHub Action Run
Source Files on build 26345173435