openmrs / openmrs-core / 26342072206
63%
master: 65%

LAST BUILD BRANCH: 2.7.x
DEFAULT BRANCH: master
Ran
Jobs 1
Files 816
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 63.395% (-0.002%) from 63.397%
26342072206

push

github

web-flow 
Backport: stop echoing properties to stdout + fix openmrs-extra typo (2.9.x) (#6118)

* Stop echoing openmrs-server.properties to stdout on startup (#6115)

The merged runtime/server properties file contains DB credentials plus
any property supplied via OMRS_EXTRA_* / OMRS_CONFIG_PROPERTY_* env vars
(API keys, bearer tokens, OAuth secrets, ...). When the container's
stdout is captured by a log sink (Docker, GitHub Actions, ELK, Loki),
those values are exposed in plaintext.

This was recently observed: a downstream module's OpenRouter API key,
supplied as OMRS_CONFIG_PROPERTY_CHARTSEARCHAI_LLM_REMOTE_APIKEY,
ended up in a public GitHub Actions log because the container's
stdout was captured.

Nothing consumes this stdout — startup.sh sources startup-init.sh and
the Java app reads the file from disk via -DOPENMRS_INSTALLATION_SCRIPT.
The cat was added in TRUNK-6184 as a diagnostic alongside OMRS_EXTRA_
support, not as an interface. Operators who need to inspect the
rendered file can read it directly from $OMRS_HOME inside the container.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Fix typo in openmrs-extra.properties.tmp path

The line that appends a trailing newline to the merged extras tmp file
referenced `openmrs-exta.properties.tmp` (missing 'r') instead of
`openmrs-extra.properties.tmp`. At every Docker container startup this
created a stray empty file `openmrs-exta.properties.tmp` in the working
directory and the intended trailing newline was never appended to the
real tmp file. In practice the downstream concatenation onto
$OMRS_SERVER_PROPERTIES_FILE was unaffected because each line is already
terminated with \n by `echo -e`, but the typo'd file name was clearly
unintended.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

23302 of 36757 relevant lines covered (63.39%)

0.63 hits per line

Coverage Regressions

Lines Coverage ∆ File
5
93.99
 -1.31% api/src/main/java/org/openmrs/util/ThreadSafeCircularFifoQueue.java
2
85.11
 -2.13% api/src/main/java/org/openmrs/validator/ConceptValidator.java
Jobs
ID Job ID Ran Files Coverage
1 26342072206.1 816
63.39
Source Files on build 26342072206