aelassas / servy / 26331006546

86%

Build Type

push

github

Committed by aelassas

Commit Message

fix(core): ServiceManager.cs - InstallServiceAsync calls GetByNameAsync with decrypt:true but only reads Pid and PreviousStopTimeout; credentials are never used (preserveExistingCredentials:false) (#1820)
fix(core): Helper.cs - IsServiceNameValid uses Msg_ServiceNameContainsTrailingWhitespace for both leading AND trailing whitespace (#1819)
fix(core): ResourceHelper.cs - CopyEmbeddedResource logs 'successfully copied' in the restart-failure branch even when the copy itself was aborted by TerminateBlockingProcesses (#1817)
fix(cli): InstallServiceOptions.cs - broken XML doc cref 'Constants.DefaultUseLocalTimeForRotation' (no such symbol); actual default lives on AppConfig (#1814)
fix(infra): SQLiteDbInitializer.cs - ReconcileSchema type-mismatch check assumes [SqlColumn] never contains anything other than 'TYPE NOT NULL', causing false positives if a DEFAULT/CHECK/COLLATE clause is ever added (#1810)
fix(service): ServiceHelper.cs / IServiceHelper.cs - LogStartupArguments 'string[] args' parameter is dead; never referenced in the body (#1792)
fix(core): ServiceDtoImportValidator.cs - TException=Exception in both JSON/XML subclasses makes the catch-all unreachable and erases the intended parser-vs-unexpected error split (#1784)
fix(desktop,manager): ServiceConfigurationValidator.cs (Servy & Servy.Manager) - XML doc references warnings, but ValidationResult has no Warnings and the code only shows errors (#1775)
fix(desktop): ServiceCommands.cs - Start/Stop/RestartService show generic 'Unexpected error' on UnauthorizedAccessException, unlike Install/Uninstall which show 'Admin rights required' (#1772)
fix(core): ServiceHelper.cs - StartServices timeout formula is inconsistent with CalculateStopTimeout; should be extracted into a symmetric helper (#1763)
fix(manager): DependenciesViewModel.cs / ConsoleViewModel.cs - copy-pasted 'so we don't clear the zeros we just added' comment refers to graph zeros that don't exist here (#1761)
fix(notifications): Servy-... (continued)

Coverage Stats

1249 of 2308 branches covered (54.12%)

Branch coverage included in aggregate %.

11 of 33 new or added lines in 10 files covered. (33.33%)

1 existing line in 1 file now uncovered.

8728 of 17552 relevant lines covered (49.73%)

421.94 hits per line