KarpelesLab / libwallet / 26319124552

22%

push

github

wltintf: read ListHelper params via *Context.GetParam directly

The 00948d8 fix used `apirouter.GetParam[any](ctx, k)` to read each
searchKey out of the apirouter request, but the typed-generic wrapper
panics when the requested key is absent and T is the bare `any`:

  panic: interface conversion: interface is nil, not interface {}
    github.com/KarpelesLab/apirouter.GetParam[...]
        apirouter@v0.5.28/context.go:261

Root cause is reflect-flavoured: `reflect.Zero(reflect.TypeOf(*any))`
round-trips as an untyped nil that fails the final `.(T)` assertion.
The CI Dart Tests run exposed it on `Network:list` (called without
a TestNet query) and `Account:list` (called without a Wallet query).

Switch to the lower-level `*apirouter.Context.GetParam(k)` accessor,
which returns the raw `any` (or nil for absent keys) without any
reflect machinery. Behaviour is otherwise identical — string-valued
empties are still skipped so they don't land in the WHERE map and
turn legitimate "no filter" requests into "rows where Wallet=''"
no-ops.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

0 of 13 new or added lines in 1 file covered. (0.0%)

4026 of 18222 relevant lines covered (22.09%)

104.44 hits per line