roocs / clisops / 26303027872

87%

Build Type

push

github

Committed by web-flow

Commit Message

Subset gridpoint masking and distance and geographic methods for all grid types (#493)

<!--Please ensure the PR fulfills the following requirements! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
  - This PR fixes issue #xyz
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Documentation has been added / updated (for bug fixes / features)
- [x] HISTORY.rst has been updated (with summary of main changes)

### What kind of change does this PR introduce?: <!--(Bug fix, feature,
docs update, etc.)-->

- Adds ability to use a boolean data mask with `subset_gridpoint` where
selected points must be within the mask (`True`)
- Allows choice between using true world distance or nearest neighbour
based on geographic (lat, lon) coords for selection of points for both
regular and irregular grids. Current implementation is inconsistent and
uses lat,lon nearest for regular grids and true distance on irregular

### Does this PR introduce a breaking change?: <!--(Has there been an
API change? New dependencies?)-->
The default method is set for `distance` (more accurate but could
potentially be slower for large grids). As such the default behaviour is
different for regular lat, lon grids potentially causing small
differences in selected locations (most likely close to poles if at all
present)

### Other information: <!--(Relevant discussion threads? Outside
documentation pages?)-->

Coverage Stats

57 of 60 new or added lines in 1 file covered. (95.0%)

1 existing line in 1 file now uncovered.

3229 of 3692 relevant lines covered (87.46%)

4.16 hits per line