prisma-risk / tsoracle / 26302662986

95%

push

github

fix(client): surface driver-task death as DriverGone (#118)

The client driver previously collapsed three causally distinct failure
modes into `ClientError::NoReachableEndpoints`: a transport-layer
collapse, the driver task's `mpsc::Receiver` going away, and a
post-send `oneshot::Sender` drop. The latter two only happen when the
in-process driver is dead (typically a panic in the user-supplied RPC
closure), and reporting them as "no reachable endpoints" sent
operators hunting the network for a local bug.

This change adds `ClientError::DriverGone` for the local-driver-dead
case, wraps the spawned `driver_task` in a small supervisor that logs
its `JoinError`, and replaces the previously-swallowed `JoinError` arm
in the chunk-task select with a `tracing::error!` so a panicked RPC
closure no longer disappears without a breadcrumb. The matching
`is_transient` matches in `benchmarks/minimal` and `benchmarks/stress`
are extended to bucket the new variant with the other non-transient
errors.

Also fixes a smaller signal-loss in `decode_leader_hint`: the three
`.ok()?` discards now route to feature-gated logging — `error!` on
the impossible-but-defensive const-key failure, `debug!` on
wire-malformed trailer bytes or protobuf decode failure.

78 of 89 new or added lines in 5 files covered. (87.64%)

7154 of 7459 relevant lines covered (95.91%)

628530.54 hits per line