cockroachdb / bubbline / 26299597644

65%

main: 65%

Build Type

Pull #3

github

Committed by petermattis

Commit Message

bubbline: thread Input/Output through to bubbletea program

GetLine() unconditionally passes the bubbletea program the process's
stdin/stdout. That works for the standalone case where the editor
runs in the foreground terminal, but it forecloses use of bubbline
as a library: an embedder that drives the editor over a PTY pair,
SSH channel, or any other non-stdio transport has no way to bind
the editor's I/O to those file descriptors.

Add two exported io.Reader/io.Writer fields on Editor, set in the
same direct-field-assignment style as MaxHistorySize, Reflow, etc.
When non-nil they are passed through as tea.WithInput / tea.WithOutput
options on the program; when nil the existing behavior is preserved
byte-for-byte, so consumers that don't set them see no change.

Pull Request Pull Request #3: Thread Input/Output through to bubbletea program

Coverage Stats

8 of 20 new or added lines in 7 files covered. (40.0%)

72 existing lines in 3 files now uncovered.

1781 of 2755 relevant lines covered (64.65%)

548.15 hits per line