prisma-risk / tsoracle / 26299074447

95%

push

github

refactor(openraft-toolkit): use parking_lot::RwLock in PartitionController (#123)

std::sync::RwLock poisons whenever a thread panics while holding a
guard. Inside test_fakes/partition.rs that turned every subsequent
reachability check into a confusing PoisonError unwrap panic at an
unrelated line, masking the original failure propagated from
MemNetwork receiver tasks and making partition tests harder to debug.

parking_lot::RwLock does not poison, so the controller stays usable
after an unrelated panic and the real cause stays in the test output.

parking_lot is already a workspace dependency; expose it to external
test-fakes consumers via an optional dep gated by the feature, mirroring
the existing rocksdb-log-store pattern so the dep stays test-only.

Adds a regression test that fires a panic from inside HashSet::insert
(via a NodeId whose Hash impl panics on a sentinel value), proves the
controller stays usable, and would re-panic with PoisonError on
std::sync::RwLock.

Closes #102.

22 of 23 new or added lines in 1 file covered. (95.65%)

6843 of 7108 relevant lines covered (96.27%)

72801.85 hits per line