prisma-risk / tsoracle / 26296852773

95%

push

github

fix(driver-openraft): map RaftError::Fatal to PermanentDriver (#112)

* fix(driver-openraft): map RaftError::Fatal to PermanentDriver

Closes #84.

`StandaloneHost::current_high_water` and `submit_advance` matched
`RaftError::ForwardToLeader` explicitly and absorbed every other variant
into `ConsensusError::TransientDriver`. That catch-all included
`RaftError::Fatal` — storage failure, raft-task panic, invariant
violation — so a fatal raft state surfaced to clients as
`UNAVAILABLE` (retryable) instead of `INTERNAL`, turning an
unrecoverable local fault into a tarpit.

Extract the classification into `classify_read_error` /
`classify_client_write_error` and route `RaftError::Fatal(_)` through
`ConsensusError::PermanentDriver`. The free-function shape lets the
unit tests construct a `RaftError::Fatal` directly and assert the
classification without standing up a raft cluster.

* test(driver-openraft): cover ForwardToLeader and transient classifier arms

Coveralls flagged four uncovered lines in `standalone.rs` introduced by
the prior commit: the `ForwardToLeader` arm of `classify_read_error`
and the `_ => TransientDriver` catch-all in both classifiers. Add
direct unit tests that construct those error shapes (ForwardToLeader,
QuorumNotEnough for the read path, ChangeMembershipError::EmptyMembership
for the client-write path) so all four arms of each classifier are
exercised.

53 of 53 new or added lines in 1 file covered. (100.0%)

6556 of 6810 relevant lines covered (96.27%)

85180.59 hits per line