Tatsh / wiswa / 26270994017

100%

push

github

templates/github/workflows: emit slashed paths for namespace modules

The PyInstaller and AppImage workflow templates' `paths:` push trigger
filter looped over `settings.modules` and emitted `{{ mod }}/**` directly
without converting the Python import-name dots to slashes. For a
project whose `primary_module_qualified` was `vendor.product.service`,
the generated workflow ended up with `vendor.product.service/**` which
never matches any real file — the workflow's `paths:` filter became a
silent dead trigger. (Wiswa's own `.github/workflows/pyinstaller.yml`
was hit by this: the path was `wiswa.tool/**` instead of `wiswa/tool/**`.)

The Jsonnet workflow generators already handle this with
`utils.moduleImportToPath(mod)`, and other parts of the Jinja templates
use `{{ ... | replace('.', '/') }}`. Apply the same `replace` filter to
the two J2 templates that loop over `settings.modules`. Add a regression
test that builds a project with a namespace-style
`primary_module_qualified = 'vendor.product.service'` and asserts that
the generated `pyinstaller.yml` / `appimage.yml` contain
`'vendor/product/service/**'` and do not contain
`'vendor.product.service/**'`.

The diff against this repo's own generated workflows (`wiswa.tool/**`
→ `wiswa/tool/**`) is included as proof the fix lands on real output.

Verified Blue-Army-style by stashing the J2 changes and re-running the
new test, which fails with the exact buggy substring.

Signed-off-by: Andrew Udvare <audvare@gmail.com>

371 of 371 branches covered (100.0%)

Branch coverage included in aggregate %.

1943 of 1943 relevant lines covered (100.0%)

5.0 hits per line