Tatsh / livecheck / 26270893129

100%

Build Type

push

github

Committed by Tatsh

Commit Message

main: defer GitHub branch lookup until ebuild is rewritten

`get_github_branch_for_commit()` was called as soon as a GitHub-release
`sha_sources` entry resolved a SHA, regardless of whether an ebuild
rewrite would actually happen. Each invocation hits the GitHub compare
API and iterates over multiple branch candidates, so livecheck runs
with `--auto-update` off (or no-op SHA bumps where `old_sha == top_hash`)
burned unnecessary rate budget per package.

Hoist `update_sha_too_source` and `github_releases_sha_source` to
function scope so the branch lookup can be performed at its sole
consumption point: inside the `settings.auto_update_flag` block,
immediately before `update_egit_branch`, guarded on
`old_sha != top_hash`. The settings-clone branch-removal still happens
unconditionally during `parse_url` so the release tag resolves on its
own ref, preserving the original fix's intent.

Update `test_do_main_sha_source_releases_ignore_existing_branch` to
assert the lookup is **not** called when no rewrite is applied (the
contract the new code enforces). Add
`test_do_main_sha_source_releases_resolves_branch_on_update`
(parametrised over a truthy and empty resolved branch) and
`test_do_main_sha_source_releases_skips_branch_when_sha_unchanged` to
cover the deferred-call paths.

Also rename a test string literal from `"oldsha"` to `"old_sha"` to
satisfy cspell, matching the suggestion already filed on the PR.

Related: https://github.com/Tatsh/livecheck/pull/476#discussion_r3269350836
Signed-off-by: Andrew Udvare <audvare@gmail.com>

Coverage Stats

575 of 575 branches covered (100.0%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

5 existing lines in 2 files now uncovered.

3018 of 3023 relevant lines covered (99.83%)

4.99 hits per line