wboayue / rust-ibapi / 26254760904

92%

push

github

historical: HistoricalTicksBuilder replaces historical_ticks_* trio (#613)

* historical: HistoricalTicksBuilder replaces historical_ticks_* trio

Collapses `historical_ticks_trade` + `historical_ticks_mid_point` +
`historical_ticks_bid_ask` (near-identical 5–6 arg signatures) into one
`HistoricalTicksBuilder` with typed terminals `.trade()` / `.mid_point()`
/ `.bid_ask(IgnoreSize)`. Mirrors `RealtimeBarsBuilder` shape.

`ignore_size: bool` (BidAsk-only on the wire) becomes `IgnoreSize` enum
(`Yes` / `No`), passed only to `.bid_ask(...)` where IBKR honors it.
Other setters: `.starting(start)` / `.ending(end)` (at least one required
per IBKR — runtime check left to the wire, not pre-flighted), and
`.trading_hours(TradingHours)` defaulting to Regular.

Shared `pub(crate) fn historical_ticks<T: TickDecoder<T>>(...)` helper
extracted in sync.rs + async.rs to dedupe the 3 near-identical method
bodies — `#[allow(clippy::too_many_arguments)]` mirrors the encoder it
bridges to.

Plan: plans/historical-data-builders.md PR 2 of 3. `IgnoreSize` exported
via prelude. Migration §25.

* historical/ticks: inline IgnoreSize::as_bool (/simplify)

Two callsites become `matches!(ignore_size, IgnoreSize::Yes)` inline.
The helper added no abstraction beyond the inline pattern-match;
removing it drops a level of indirection.

Findings explicitly skipped: BID_ASK_RESPONSE duplicates an inline
literal in sync_tests.rs (pre-existing; shared-module reshape is
out of scope); asymmetric TickSubscription qualification is forced
by the feature-flag aliasing structure (rule 12); per-feature
helper duplication and 6 near-identical terminals are accepted
project precedent (RealtimeBarsBuilder mirror).

* historical/async_tests: cargo fmt import order

145 of 147 new or added lines in 3 files covered. (98.64%)

19043 of 20659 relevant lines covered (92.18%)

28.08 hits per line