DrRataplan / xq-lsp / 26248711762

93%

Build Type

push

github

Committed by web-flow

Commit Message

fix: scope-aware type checking for function params and bindings (#24)

* fix: isolate variable type scopes per function to eliminate cross-function false positives

Each named function declaration now gets its own variable type scope
(module-level vars + its own params + its own let/for bindings).
InlineFunctionExpr nodes also get isolated scopes.

Previously buildVarTypes collected all bindings from the entire module
into a single flat map, causing params from one function (e.g. m:baz's
$some-random-name as xs:string) to pollute type inference in sibling
functions (e.g. m:entry's untyped let $some-random-name := m:foo()),
producing spurious XPTY0004 warnings.

Fixes #21

https://claude.ai/code/session_01NwsEpir4V7bUr5S6VRN5AU

* fix: preserve full type string for map/array/function in parseType

parseType was discarding the content of map(*), array(*), and
function(*) types, so formatType rendered them as "map", "array",
"function" — missing the parentheses and content in error messages.

Storing the full base type in the name field (same pattern as node
kinds) makes formatType produce the correct "map(*)", "array(*)",
"function(*)" strings.

https://claude.ai/code/session_01NwsEpir4V7bUr5S6VRN5AU

---------

Co-authored-by: Claude <noreply@anthropic.com>

Coverage Stats

413 of 536 branches covered (77.05%)

Branch coverage included in aggregate %.

110 of 117 new or added lines in 1 file covered. (94.02%)

44 existing lines in 3 files now uncovered.

1634 of 1744 relevant lines covered (93.69%)

1757.86 hits per line