umputun / revdiff / 26247763844

90%

push

github

Add annotation exit code for automation (#206)

* feat: add annotation exit code option

* feat: preserve annotation exit code in launchers

* feat: handle annotation exit code in callers

* test: cover annotation exit code integrations

* docs: document annotation exit code handling

* chore: archive annotation exit code plan

* fix: address PR #206 review

- suppress shellcheck SC2016 on write_rc_cmd/write_fifo_rc_cmd printf
  format strings; single quotes are intentional so $?/$rc stay literal
  for the generated inner launcher script (fixes lint-scripts CI failure)
- pi overlay review: treat signal termination and null exit status as
  errors instead of defaulting to exit 0, which masked interrupted runs
  as clean reviews

* docs: defer plugin version bumps until binary release

plugin and binary version independently; bumping plugin.json /
marketplace.json / package.json before the binary is tagged ships an
updated launcher to users on an old binary, causing a flag mismatch

* refactor: enable exit-code-on-annotations via env var, not CLI flag

bundled launchers and the pi extension now request exit code 10 by
setting REVDIFF_EXIT_CODE_ON_ANNOTATIONS=true instead of passing the
--exit-code-on-annotations flag. an old revdiff binary silently ignores
an unknown env var but hard-fails on an unknown flag, so this removes
the plugin/binary version-skew hazard where an updated launcher meets a
stale binary. the --exit-code-on-annotations CLI flag stays as a public
standalone option.

fake-revdiff test fixture now asserts the env var is set so launcher
tests prove all backends propagate it.

* test: assert deny-path stdout is empty in plan-review hook test

TestPlanReviewHookAnnotationExitCodes left wantStdout unset for the
annotations case, making assert.Contains(stdout, "") a no-op. gate the
stdout assertion on wantStdout like the wantStderr block already does, so
the deny path (exit 2, stderr-only) is verified to emit nothing to stdout.

13 of 35 new or added lines in 1 file covered. (37.14%)

9793 of 10905 relevant lines covered (89.8%)

3184.84 hits per line