dangernoodle-io / breadboard / 26243012956

100%

push

github

fix(bb_http): actually enable LWIP_NETCONN_SEM_PER_THREAD via CMake (B1-228) (#301)

LWIP_NETCONN_SEM_PER_THREAD is a lwip C macro, not an ESP-IDF Kconfig
symbol. PR #295's `select LWIP_NETCONN_SEM_PER_THREAD` directive was a
silent no-op — Kconfig only `select`s other Kconfig symbols, and lwip
exposes none for this knob. CONFIG_BB_HTTP_LWIP_SEM_PER_THREAD shipped
=1 in consumer builds but CONFIG_LWIP_NETCONN_SEM_PER_THREAD never
materialized; the per-thread sem path never compiled in.

Verified by grep on a downstream consumer's build sdkconfig.h: knob
present, define absent. Same consumer kept aborting in lwip_select on
the same backtrace we cited as justification for #295, despite the
knob being on. The "fix" never reached the runtime.

Switch to injecting -DLWIP_NETCONN_SEM_PER_THREAD=1 into build-wide
COMPILE_OPTIONS from bb_http's CMakeLists when the Kconfig knob is on.
Verified on a downstream consumer: the define now lands in every
compile command in compile_commands.json.

Resolves B1-228. Re-opens B1-224 validation (it was never actually
running on bench).

1206 of 1206 branches covered (100.0%)

Branch coverage included in aggregate %.

2088 of 2088 relevant lines covered (100.0%)

921.2 hits per line