Alan-Jowett / sonde / 26242190064

82%

push

github

feat: add GetGatewayState and SubmitRotation gRPC RPCs (GW-2012) (#1051)

* feat: add GetGatewayState and SubmitRotation gRPC RPCs (GW-2012)

Add two new RPCs to the gateway admin gRPC service for key management:

- \GetGatewayState\: returns gateway identity, master key ID/epoch,
  X25519 public key, BIP-39 fingerprint, salt, KDF params, rotation
  status, and version info. Used by admin CLI \key fingerprint\,
  \key status\, and \key rotate\ commands.

- \SubmitRotation\: accepts a \RotationPayloadV1\ binary and forwards
  it to the gateway engine via an async channel with oneshot response.
  Returns \{accepted, error}\. Both this gRPC path and the
  DESIRED_STATE connector path converge on the same rotation handler.

Proto changes:
- Added \GatewayState\, \KdfParameters\, \SubmitRotationRequest\,
  \SubmitRotationResponse\ messages to admin.proto

Implementation:
- \AdminService\ gains \otation_tx\ channel (typed via
  \RotationSubmitChannel\ alias) for forwarding payloads to the engine
- \with_rotation_tx()\ builder method for wiring at startup
- \get_gateway_state()\ reads from storage + gateway identity
- \submit_rotation()\ validates and forwards via channel

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix: address PR #1051 review — validation, error handling, correctness

- Use \identity.gateway_id()\ instead of nonexistent \gateway_id_hex\ config
- Validate \master_key_id\ length (16 bytes) after hex decode
- Return error on malformed channel/salt/kdf_params (not silent fallback)
- Validate salt length (16 bytes) when present
- Check \pending_rotation_phase\ config for rotation status (not
  nonexistent \otation_in_progress\ key)
- Use \SONDE_GIT_COMMIT\ env var (matches build.rs), not \SONDE_BUILD_COMMIT\
- Enforce 1024-byte max on rotation payload in \submit_rotation()\
- Fix \KdfParamsJson\ doc comment (deserializable, not serializable)

Co-authored-by: Co... (continued)

1 of 21 new or added lines in 1 file covered. (4.76%)

37086 of 44887 relevant lines covered (82.62%)

252.12 hits per line