prisma-risk / tsoracle / 26241541035

95%

push

github

chore(core): drop panicking convenience wrappers from Allocator (#34)

* chore(core): drop panicking convenience wrappers from Allocator

The convenience wrappers `on_leadership_gained`, `prepare_window_extension`,
and `commit_window_extension` each called the corresponding `try_*` variant
and `.expect()`-ed the result. Production code (server `fence::run_leader_watch`
and the service extension path) already went through the `try_*` API, so the
wrappers existed only for test ergonomics — at the cost of a panic surface on
the core crate's public API that each required a
`#[expect(clippy::expect_used, ... Tracked by #4)]` silencer to placate the
runtime-panic lint added in #28.

Remove the wrappers. The ~24 inline-test callsites and the 3 proptest callsites
in `tests/monotonicity.rs` now call the `try_*` variants directly and
`.unwrap()` the `Result`, matching how the existing `try_grant` callers were
already written. The `Allocator`'s public surface is now exclusively fallible
for any operation that can fail. The `expect_used` lint from #28 continues to
prevent regression and no longer has any #4-tracked silencers to circumvent it.

Also fixes two stale doc-comment references inside `allocator.rs` (the
`committed_high_water` field comment and the `try_prepare_window_extension`
doc) that pointed at the now-removed bare `commit_window_extension` name.

Closes #4.

* chore(fmt): rustfmt allocator tests after wrapper removal

The single-line `allocator.try_*(...).unwrap()` calls introduced in
29c58a2 exceeded rustfmt's default 100-char limit, so rustfmt wants
each broken across three lines. Also drops the trailing blank line
at the end of the `impl Allocator` block. No behavior change.

CI's `cargo fmt --check` step caught this; the repo's tracked
pre-commit hook at .githooks/pre-commit would have caught it locally
too, but it's opt-in via `make install-hooks` and was not enabled in
this clone.

62 of 62 new or added lines in 1 file covered. (100.0%)

4615 of 4860 relevant lines covered (94.96%)

110289.61 hits per line