reside-eng / workflow-ci-analytics-action / 26237273684

97%

push

github

fix: modernize toolchain to ESM (biome, vitest, esbuild, lefthook) (#76)

* fix: modernize toolchain to ESM (biome, vitest, esbuild, lefthook)

Mirrors reside-eng/npm-dependency-stats-action#1655 (closest analog) and
adds Claude Code scaffolding per reside-eng/test-service-ci#692.

Toolchain swap:
- husky/lint-staged/pinst -> lefthook
- @vercel/ncc -> esbuild (single ESM bundle at dist/index.mjs)
- CJS -> ESM end-to-end: "type": "module", .js extensions on relative
  imports, dist target moved to dist/index.mjs in action.yml
- @actions/core 1.x -> 3.0.1 (ESM-only as of 3.0)
- vitest 2.1.9 -> 4.1.5; @biomejs/biome -> 2.4.15
- tsconfig now extends @tsconfig/node24/tsconfig.json

Config:
- biome.jsonc adopts the canonical Side-org ruleset
  (complexity/correctness/style/suspicious; vcs.useIgnoreFile;
  useEditorconfig; bin/** + test overrides)
- new lefthook.yml runs check:fix:staged + types:check + build sequentially
  on pre-commit, keeping dist/README in sync (existing behavior)
- new build.mjs derives esbuild --target from engines.node
- new .editorconfig, vitest.config.ts (replaces .mts), 75% coverage gate
- commitlint.config.js renamed to .cjs (required under "type": "module")
- js-yaml + @types/js-yaml declared explicitly (was phantom transitive
  via @google-cloud/bigquery)

Source fixes:
- console.error(err) -> core.error(err) in handleError (proper GH Actions
  annotation; also resolves biome noConsole)
- vi.mock('@actions/github') hoisted to module top (vitest 4 deprecation)
- BigQuery mockImplementation switched to `function`-form (vitest 4
  requires this for new-able mocks); biome-ignore comments document why

Scaffolding:
- AGENTS.md (stack/scripts/conventions, stale-husky-hooksPath gotcha)
- CLAUDE.md (one-line pointer to AGENTS.md)
- .claude/{commands,agents}/.gitkeep
- .gitignore block for .claude/{worktrees,memory,projects,settings.local.json}

CI:
- verify.yml + release.yml swapped `yarn lint` -> `yarn check` and added
  an explicit `... (continued)

6 of 7 branches covered (85.71%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

61 of 62 relevant lines covered (98.39%)

2.1 hits per line