Logflare / logflare / 0be38c1a79a9d1a48536280723b4249f890492c9

80%

Build Type

push

github

Committed by web-flow

Commit Message

fix: verify Stripe webhook signatures to prevent forged billing events (#3423)

* fix: verify Stripe webhook signatures using Stripe.WebhookPlug

- Add Stripe.WebhookPlug to the endpoint before Plug.Parsers so raw
  body bytes are available for HMAC-SHA256 signature verification
- Move billing event logic from StripeController into a new
  LogflareWeb.StripeWebhookHandler that implements Stripe.WebhookHandler
- Remove the now-redundant /webhooks/stripe router route
- Read the webhook secret from STRIPE_WEBHOOK_SECRET env var at runtime
- Update tests to sign requests with a test secret and assert against
  WebhookPlug response semantics (400 on bad/missing signature)

Closes PRODSEC-35

Co-authored-by: Brian Cullen <brianshan@gmail.com>

Coverage Stats

62 of 70 new or added lines in 6 files covered. (88.57%)

8 existing lines in 1 file now uncovered.

12646 of 15729 relevant lines covered (80.4%)

3755.62 hits per line