tari-project / tari / 26223687530
61%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 702
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 60.422% (-0.02%) from 60.442%
26223687530

push

github

web-flow 
feat(xmrig-proxy): add getinfo and getheight methods to the node's integrated xmrig_proxy (#7827)

Description
---
Some third-party applications request getinfo and/or getheight

This PR adds dedicated handlers for getinfo and getheight while
preserving compatibility with clients which may be calling get_height or
getblockcount

Modifications:
- Implemented handle_get_height_hash() and handle_get_info() with
explicit routing
- Extracted shared chain tip into get_chain_tip() for use in all
handlers
- Registered corresponding GET paths (/getheight, /getinfo, /get_info)
- Added Cucumber integration tests validating all endpoints and dynamic
height updates

These additions improve miner interoperability without altering the
existing proxy functionality. Redundant node service calls are
consolidated

Motivation and Context
---
Mining and mining pool software often expects a get_info/getinfo
endpoint and may use getheight instead of get_height. By giving
getheight its own handler rather than merging it with get_height, this
PR:

- Preserves compatibility — existing getblockcount/get_height clients
see no change
- Provides enriched data to getheight callers (block hash alongside
height)
- Adds compatible get_info and getinfo for applications expecting them

How Has This Been Tested?
---
Cucumber Test Coverage: Test Scenarios (6 total)
 **| Scenario                     | Method | Endpoint | Validation**

1 | JSON-RPC getheight | POST | getheight | Response contains height,
id, status
2 | JSON-RPC getinfo | POST | getinfo | Response contains height, id,
status, credits
3 | GET /getheight | GET | /getheight | Response contains height, id,
status
4 | GET /getinfo | GET | /getinfo | Response contains height, id,
status, credits
5 | JSON-RPC getheight reflects mined blocks | POST + mining | getheight
| Height matches base node after mining 3 blocks
6 | GET /getheight reflects mined blocks | GET + mining | /getheight |
Height matches base node after mining 3 blocks... (continued)

70473 of 116635 relevant lines covered (60.42%)

222750.16 hits per line

Coverage Regressions

Lines Coverage ∆ File
20
72.92
 -10.42% comms/dht/src/connectivity/metrics.rs
12
59.67
 -0.56% comms/dht/src/connectivity/mod.rs
10
61.55
 0.46% comms/core/src/connectivity/manager.rs
9
92.14
 -1.91% comms/dht/src/outbound/broadcast.rs
3
86.7
 -0.38% comms/dht/src/actor.rs
2
85.42
 -0.46% base_layer/p2p/src/services/liveness/service.rs
2
81.36
 -3.39% comms/core/src/pipeline/outbound.rs
1
28.0
 -4.0% base_layer/core/src/base_node/sync/header_sync/error.rs
1
60.34
 -0.17% base_layer/core/src/base_node/sync/header_sync/synchronizer.rs
1
93.76
 -0.19% base_layer/core/src/proof_of_work/monero_rx/merkle_tree.rs
1
81.16
 -0.21% comms/core/src/noise/socket.rs
Jobs
ID Job ID Ran Files Coverage
1 26223687530.1 702
60.42
 GitHub Action Run
Source Files on build 26223687530