MushroomObserver / mushroom-observer / 26223616569

Pull #4315

github

Fix lint + tidy uncovered branches introduced by the refactor

- `test/system/observation_form_system_test.rb`: shorten local var
  name to fix line-length lint regression from the earlier
  `observation_project_ids_` selector rename.
- `validators.rb`: drop the unused `submitted_list_ids` helper —
  added it for symmetry with `submitted_project_ids` but nothing
  actually calls it. Dead code.
- `new.rb#add_field_slip_project`: collapse the multi-line
  `filter_map` back to a single `select` expression. Restores
  main's branch-on-one-line coverage profile (line coverage doesn't
  count branches within an expression as separately uncovered).
  Functionally identical.

All 1259 component + obs-controller tests pass; 9 obs-form system
tests pass; rubocop clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

149 of 149 new or added lines in 11 files covered. (100.0%)

38672 of 40136 relevant lines covered (96.35%)

666.46 hits per line